[SE-2960] Add roles to project members qgl query #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstorts
force-pushed
the
jstorts/add-roles-to-project-members
branch
from
5687c44 to
dc44aa8
Compare
msokoloff1
reviewed
Jul 28, 2023
jstorts
force-pushed
the
jstorts/add-roles-to-project-members
branch
2 times, most recently
from
0afaae8 to
cc72ffe
Compare
jstorts
commented
Jul 28, 2023
jstorts
force-pushed
the
jstorts/add-roles-to-project-members
branch
from
cc72ffe to
a5cf49a
Compare
kkim-labelbox
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Context
A user has requested the roles of project members be returned in the SDK response. This GQL query is already being made by the App. As discussed in the Slack thread, exposing the
accessFromfield has a risk of introducing latency.If possible, the updated query should be released for beta testing to further test the performance when used for programmatic access.
Slack Thread
Analysis
Datadog APM
The analysis shows that the queries made by both the App and the SDK are somewhat expensive because the resolver has to iterate several collections to compute the result.
The difference between query performance with the field (in the App) and query performance without the field (in the SDK today) was not large enough to be significant.
Description
If merged, this PR adds the
accessFromfield to theProjectMemberOverviewPyApiquery. This field resolves to the role assigned to each member of a project within that project.